[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1912 - trunk/subversion/include trunk/subversion/libsvn_subr trunk/subversion/libsvn_repos

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2002-05-11 17:30:50 CEST

On Thu, 2002-05-09 at 00:23, sussman@tigris.org wrote:
> + while (1)
> + {
> + numbytes = 1;
> + SVN_ERR (svn_stream_read (stream, &c, &numbytes));
> +
> + if ((c == '\n'))
> + break;
> +
> + svn_stringbuf_appendbytes (str, &c, 1);
> + }

This seems likely to be a real performance killer.

I think you need to create a buffered stream object if you want to
abstract out line-reading. Or maybe just reevaluate whether you really
need an svn_stream here, instead of something less generic like an APR
file.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 11 17:31:41 2002

This is an archived mail posted to the Subversion Dev mailing list.