Re: svn commit: rev 1919 - trunk/subversion/clients/cmdline

Branko Čibej wrote:

> Karl Fogel wrote:
>
>> Justin Erenkrantz <jerenkrantz@apache.org> writes:
>>
>>
>>> In case you aren't following dev@apr, I just brought up removing
>>> this macro. -- justin
>>>
>>
>>
>> +1 from me (although I'm *still* wondering about those OS2 and WIN32
>> cases!)
>>
>>
> It's nonsense, at least on Windows. Look at how APR_FROM_OS_ERROR is
> defined. ERROR_SUCCESS is also guaranteed to be zero, so it's mapped
> directly ti APR_SUCCESS.
>
> Come to think of it, Win32 also has NO_ERROR, which is the same as
> ERROR_SUCCESS. OS/2 legacy, no doubt.
>
> I'm all for tossing that macro.
>
And I just noticed that APR_TO_OS:_ERROR is wrong. Actually, both are
wrong :-)

Should be:

#define APR_FROM_OS_ERROR(e) ((e) == ERROR_SUCCESS ? APR_SUCCESS : (e) + APR_OS_START_SYSERR)
#define APR_TO_OS_ERROR(e) ((e) == APR_SUCCESS ? ERROR_SUCCESS : (e) + APR_OS_START_SYSERR)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org