[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1892 - trunk/subversion/libsvn_client

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-05-07 19:49:51 CEST

On Mon, May 06, 2002 at 08:58:39PM -0500, sussman@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_client/repos_diff.c Mon May 6 20:58:32 2002
>...
> - dir_baton->path = svn_path_join (apr_pstrdup (pool, eb->target->data), path,
> - pool);
>...
> - file_baton->path = svn_path_join (apr_pstrdup (pool, eb->target->data), path,
> - pool);

If you ever put this back in, note that you do NOT need to dup the string
before passing it to join(). join() is guaranteed to always return its value
in the new pool.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 7 19:48:34 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.