[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 4 bugs in svn diff (IssueZilla gives me Internal Server Error)

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-04-28 19:09:50 CEST

On Sun, Apr 28, 2002 at 09:52:19AM -0400, Garrett Rooney wrote:
> On Sat, Apr 27, 2002 at 11:41:40PM -0500, Ben Collins-Sussman wrote:
>
> > >
> > > #################################################################
> > > svn diff dumps core when listing property changes
> >
> > Looks like garrett fixed this...
>
> actually, not yet. i can fix it, by just checking that the hash is
> valid before trying to look something up in it, but i'm still curious
> if it's legal for that function to be called with a null pointer for
> the hash. if there are no original props, shouldn't it be called with
> an empty hash, not a null pointer?

ok, i've looked a little closer, and it seems that the hash is indeed
allowed to be NULL, so i'll commit a fix shortly.

-garrett

-- 
garrett rooney                    Remember, any design flaw you're 
rooneg@electricjellyfish.net      sufficiently snide about becomes  
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 28 19:10:50 2002

This is an archived mail posted to the Subversion Dev mailing list.