[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1752 - trunk/subversion trunk/subversion/include trunk/subversion/libsvn_diff

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-04-25 13:31:27 CEST

Zack Weinberg <zack@codesourcery.com> writes:

> On Thu, Apr 25, 2002 at 03:20:56AM +0200, Sander Striker wrote:
> > I always wondered why we needed that \No newline at end of file crap.
> > If there is no newline on the end of file, don't output a newline.
> > What's wrong with that?
>
> That would be far too easily lost or confused. For instance, if the
> diff is embedded in an e-mail message (which happens all the time) or
> if there's a diff of another file after that one (ditto), a newline
> will get added, or the boundary between diff and what-comes-after will
> be mangled.

It's worse than that, it simply doesn't work. For instance the patch

@@ -2,4 +2,4 @@
 B
 C
 D+1
-E+1
\ No newline at end of file
+E-1

would become

@@ -2,4 +2,4 @@
 B
 C
 D+1
-E+1+E-1

which a) will confuse existing tools, and b) even a custom tool could
not decide where to split the last patch line.

We need the '\ No newline' stuff.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 25 13:32:34 2002

This is an archived mail posted to the Subversion Dev mailing list.