[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] VC warnings

From: Branko Čibej <brane_at_xbc.nu>
Date: 2002-04-23 22:29:01 CEST

Sander Striker wrote:

>>From: Sander Striker [mailto:striker@apache.org]
>>Sent: 23 April 2002 15:13
>>
>
>>Hi,
>>
>>Got lots of warnings on the windows build. This takes care
>>of them. Not sure we want to typecast ourselves into oblivion
>>though.
>>
>>This patch deliberately has no log msg (each cast needs review).
>>
>>Thoughts?
>>
>
>Ofcourse Bill Tutt was the first to bonk me on the head for this.
>We need to fix the typing rather than doing casts. There were
>a few legit casts IMHO, but I agree with Bill.
>
Yep, that's exactly why I haven't done it, and tolerate the warnings
instead.

>Is this in the issue db somewhere already? I couldn't find
>one, but didn't search very hard.
>
I think there's something there about using a 64-bit type for file
offsets everywhere (instead of apr_off_t, which isn't consistent across
platforms), which resulted from discussion about these warnings.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 23 22:30:10 2002

This is an archived mail posted to the Subversion Dev mailing list.