[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1694 - trunk/subversion/tests/clients/cmdline/svntest

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-04-15 09:15:25 CEST

Hmm. That change should not have had to go in. shutil.copytree() *does* try
to copy the permission information. It calls os.chmod() to do so. (it also
copies the timestamp)

Are you sure it wasn't copying the mode bits, and it is simply that the
Apache process needed the a+rw ? i.e. your source files didn't have the
right permissions?

Basically, I'm suspicious of this change. I'd tend to be at a -1 on it
without knowing more about the source and destinations perms that you were
trying to achieve.

Cheers,
-g

On Sat, Apr 13, 2002 at 11:25:29AM +0200, Sander Striker wrote:
> Hi,
>
> Apparently shutil.copytree() doesn't copy permissions
> without applying umask. I don't know if there is an
> equivalent of 'cp -a' in shutil, so I choose the easy
> way out.
>
> Without this, every test over dav was failing as soon
> as something needed to be written. And, as I don't
> want to adjust my umask settings... :)
>
> Sander
>
>
> > Author: striker
> > Date: 2002-04-13 09:02 GMT
> > New Revision: 1694
> >
> > Modified:
> > trunk/subversion/tests/clients/cmdline/svntest/actions.py
> > Log:
> > * subversion/tests/clients/cmdline/svntest/actions.py
> >
> > (guarantee_greek_repository): Fix a permission problem.
> >
> >
> > Modified: trunk/subversion/tests/clients/cmdline/svntest/actions.py
> > ==============================================================================
> > --- trunk/subversion/tests/clients/cmdline/svntest/actions.py (original)
> > +++ trunk/subversion/tests/clients/cmdline/svntest/actions.py Sat Apr 13 04:02:54 2002
> > @@ -90,6 +90,10 @@
> > if not os.path.exists(os.path.dirname(path)):
> > os.makedirs(os.path.dirname(path))
> > shutil.copytree(main.pristine_dir, path)
> > +
> > + # make the repos world-writeable, for mod_dav_svn's sake.
> > + os.system('chmod -R a+rw ' + path)
> > +
> > if os.path.exists(main.current_repo_dir):
> > os.unlink(main.current_repo_dir)
> > os.symlink(os.path.basename(path), main.current_repo_dir)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 15 09:15:51 2002

This is an archived mail posted to the Subversion Dev mailing list.