Re: svn commit: rev 1508 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/bindings/ruby

Ben Collins-Sussman <sussman@collab.net> writes:

> cmpilato@collab.net writes:
>
> > 2. (much more involved solution) Promote all entry members to
> > first-class citizens, and in doing so, might I recommend losing
> > the "attributes" hash that lives in the entry, too? That hash is
> > a transient state between disk and structure, and need not be
> > toted around everywhere we go. The day someone actually has
> > custom entry things to track, a hash for ONLY those custom items
> > can be re-added.
>
> Karl and I have been talking about doing this for a while now. It's
> the Right Thing.

Heh, I wonder if this means that the modify_entry function will now
look something like:

modify_entry (svn_wc_entry_t *entry, /* the entry to modify */
              svn_wc_entry_t *new_vals, /* a nice place to hold new values */
              apr_uint16_t modify_flags, /* bit-mask of which values to mod */
              apr_pool_t *pool) /* our favoritest structure in svn */

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 14 16:42:39 2002