[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1454 - trunk trunk/subversion/clients/cmdline trunk/subversion/tests/clients/cmdline/svntest

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-03-08 06:30:08 CET

This rocks!

Also, it occurs to me that the trace editor can *detect* whether or
not it's being driven in postfix or infix txdelta mode, and simply not
print "Transmitting..." if infix (just check to see if dir baton got
closed before file baton). In fact, it doesn't even have to be a
consistent drive, it can be mixed-mode, since postfixness can be
detected for each individual file baton.

Thoughts?,
-K

sussman@tigris.org writes:
> Log:
>
> Our commit-driver sends "postfix" textdeltas, so that the server can
> reject any conflicts as early as possible. However, with really large
> commits, this means 90% of the commit-time is spent after all the
> "Sending" lines have already been printed out. The user just sits
> there, wondering what's going on while txdeltas are sent.
>
> This change makes the trace-commit editor print feedback as it sends
> txdeltas.
>
> * trace-commit.c (struct edit_baton): new 'started_sending_txdeltas'
> boolean.
>
> (apply_textdelta): use boolean to inform user that postfix txdeltas
> have begun: "Transmitting file data ..." Print a '.' after each
> file's contents have been sent.
>
> (close_edit): print final '\n' after the dots.
>
> (svn_cl__get_trace_commit_editor): initialize boolean, use
> apply_textdelta.
>
> * actions.py (run_and_verify_commit): make python tests ignore the
> penultimate "Transmitting file data ..." line, if present at all.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 8 06:19:25 2002

This is an archived mail posted to the Subversion Dev mailing list.