Re: svn commit: rev 1351 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_client

On Thu, Feb 21, 2002 at 03:37:40PM -0600, Karl Fogel wrote:
> Greg Stein <gstein@lyra.org> writes:
> > > Log:
> > > Promote diff_cmd_t to a non-library-specific type, in preparation for
> > > generalization to handle merging.
> >
> > Rather than putting all kinds of libsvn_subr into svn_types.h, it seems that
> > we ought to create an svn_subr.h header. Continuing to load stuff into
> > svn_types.h "infects" the rest of the system with stuff that isn't really
> > "core" to SVN.
>
> ? I would think this is exactly the sort of thing that belongs in
> svn_types.h -- we made svn_types.h specifically for things like this.
> What would the advantage of "svn_subr.h" be? I'm not seeing the
> distinction between core and non-core that you see...

I see svn_types.h as a "global" header. With stuff that is globally
applicable to almost everything. But if you look at svn_types.h, there are a
lot of things that are a bit weird:

* svn_error_t : good

* APR_ARRAY_IDX : probably should go to apr_tables.h

* svn_node_kind_t : good

* svn_revnum_t and assorted macros : good

* boolean stuff : sucks to do it yet again :-), but good

* a TON of property stuff. kinds, catgorization, prefixes, names, entry
  attributes(!) : what is this stuff in here for? answer: because
  svn_types.h is the least common denominator. the kitchen sink. these
  aren't types, but definitions. and they aren't globally useful. for the
  most part, they are client/WC things.

* keyword definitions : similar to props

* svn_log_message_receiver_t : a type, so "okay", but it really is kind of
  from left field.

* SVN_STREAM_CHUNK_SIZE : decent, but more of an svn_defs.h kind of thing

Anyhow, with the diff thing, I see that more as a function of svn_io.h or a
higher-level svn_subr.h type thing. But svn_types? nah...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org