[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 1273 - trunk/subversion/libsvn_ra_dav

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2002-02-14 18:14:56 CET

On Thu, Feb 14, 2002 at 10:29:56AM -0600, Karl Fogel wrote:
> kevin@tigris.org writes:
> > [...]
> > }
> > else
> > {
> > - subdir_t *subdir = apr_palloc(pool, sizeof(*subdir));
> > + if (recurse)
> > + {
> > + subdir_t *subdir = apr_palloc(pool, sizeof(*subdir));
> > [...]
>
> Any reason not to fold this into one "else if (recurse)"? Is there a
> future `else' case planned for the "if (recurse)"?
>
Nothing specific, I just generally try to have else if (conditions) only check
conditions related to the original if, for clarity's sake. I'm fine either
way.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  • application/pgp-signature attachment: stored
Received on Sat Oct 21 14:37:08 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.