Re: svn commit: rev 1273 - trunk/subversion/libsvn_ra_dav

kevin@tigris.org wrote:
>
> Author: kevin
> Date: 2002-02-14 15:23 GMT
> New Revision: 1273
>
> Modified:
> trunk/subversion/libsvn_ra_dav/fetch.c
> Log:
> Partially fix Issue 624. See the issue for details.
>
> + subdir_t *subdir = apr_palloc(pool, sizeof(*subdir));
>
> - subdir->rsrc = r;
> - subdir->parent_baton = dir_baton;
> + subdir->rsrc = r;
> + subdir->parent_baton = dir_baton;
>

Shouldn't apr_palloc be checked for a NULL return, otherwise these next
dereferences will core dump. Of course, there's bigger problems if there's
no memory left, but still, for safe coding.

Best,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:07 2006