[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Um, why do we strip the SVNDIFF header for local writing

From: <cmpilato_at_collab.net>
Date: 2002-02-14 06:12:32 CET

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Daniel Berlin <dan@dberlin.org> writes:
> > However, while this works great remotely (since we can just grab the
> > char after 'SVN' and do the right thing depending on the version), we
> > strip the 'SVN\0' header locally in rep-strings.c, and send 'SVN\0'
> > through when we read back the string to fake out the stream.
> >
> > This completely defeats the purpose of the version number in there, and
> > guarantees that we can't easily change svndiff formats without destroying
> > the data in the local repository. You have to resort to shifting tricks
> > in the offset or something in your actual new algorithm, rather than just
> > using a different number after the 'SVN' part.
>
> The mistake is mine -- I didn't know the 0 was a version number,
> although Greg Hudson did document that fact in notes/svndiff.
>
> The goal wasn't to save space (as you rightly point out, it would have
> been a pathetically small optimization).

Actually, the mistake is mine. I implemented that code, and I chose
to leave off the SVN\0 (for the same reasons Karl noted though, so
even if I hadn't been the one to blame, Karl would have :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:07 2006

This is an archived mail posted to the Subversion Dev mailing list.