Yoshiki Hayashi <yoshiki@xemacs.org> writes:
> > +/* Allocate and return an array *REVS of svn_revnum_t revisions in
> > + which PATH under ROOT in FS was modified. Use POOL for all
> > + allocations.
> > +
> > + NOTE: This function uses node-id ancestry alone to determine
> > + modifiedness, and therefore does NOT claim that in any of the
> > + returned revisions file contents changed, properties changed,
> > + directory entries lists changed, etc. */
> > +svn_error_t *svn_fs_revisions_changed (apr_array_header_t **revs,
> > + svn_fs_t *fs,
> > + svn_fs_root_t *root,
> > + const char *path,
> > + apr_pool_t *pool);
> > +
> >
> > /* Set *IS_DIR to non-zero iff PATH in ROOT is a directory.
> > Do any necessary temporary allocation in POOL. */
> >
>
> I thought about writing Ruby binding for this function and a
> bit surprised to see there're both svn_fs_t and
> svn_fs_root_t arguments. Why svn_fs_t is there? I think
> tree.c can access inside svn_fs_root_t and it can use
> root->fs.
Ya know, that's a good point. I'm still actively working in
filesystem code right now, and so will make a point of reviewing the
option of removing the FS parameter's here. I totally forgot that
svn_fs_root_fs (root) existed (which is preferred over just root->fs
in case that underlying implementation changes).
Thanks, Yoshiki!
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:07 2006