[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] if ! is not portable

From: Sander Striker <striker_at_apache.org>
Date: 2002-02-09 18:41:40 CET

> From: Blair Zajac [mailto:blair@orcaware.com]
> Sent: 09 February 2002 18:31

> Using "if ! ..." does not work on Solaris. This patch fixes this.
>
> Best,
> Blair
>
> --
> Blair Zajac <blair@orcaware.com>
> Web and OS performance plots - http://www.orcaware.com/orca/
>
>
> Index: ./build/buildcheck.sh
> ===================================================================
> --- ./build/buildcheck.sh
> +++ ./build/buildcheck.sh Sat Feb 9 09:24:01 2002
> @@ -69,12 +69,16 @@
> # check that our local copies of files match up with those in APR(UTIL)
> #
> if test -d ./apr; then
> - if ! cmp -s ./ac-helpers/find_apr.m4 ./apr/build/find_apr.m4; then
> + if cmp -s ./ac-helpers/find_apr.m4 ./apr/build/find_apr.m4; then
> + :
> + else

I would suggest:

     if [ ! cmp -s ./ac-helpers/find_apr.m4 ./apr/build/find_apr.m4 ]; then

instead.

> echo "buildcheck: local copy of find_apr.m4 does not match APR's copy."
> echo " An updated copy of find_apr.m4 may need to be checked
> in."
> exit 1
> fi
> - if ! cmp -s ./build/PrintPath ./apr/build/PrintPath; then
> + if cmp -s ./build/PrintPath ./apr/build/PrintPath; then
> + :
> + else
> echo "buildcheck: local copy of PrintPath does not match APR's copy."
> echo " An updated copy of PrintPath may need to be checked in."
> exit 1
> @@ -84,7 +88,9 @@
> fi
>
> if test -d ./apr-util; then
> - if ! cmp -s ./ac-helpers/find_apu.m4 ./apr-util/build/find_apu.m4; then
> + if cmp -s ./ac-helpers/find_apu.m4 ./apr-util/build/find_apu.m4; then
> + :
> + else
> echo "buildcheck: local copy of find_apu.m4 does not match APRURIL's copy."
> echo " An updated copy of find_apu.m4 may need to be checked
> in."
> exit 1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:06 2006

This is an archived mail posted to the Subversion Dev mailing list.