[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Peer-reviewed commits

From: Justin Erenkrantz <jerenkrantz_at_ebuilt.com>
Date: 2002-02-08 00:10:04 CET

On Thu, Feb 07, 2002 at 09:01:41AM -0800, Sean Russell wrote:
> I got to thinking of how Slashdot works, and how that would be a good model
> for commit review. Developers would moderate; the system would choose
> commits at random and allow the developer to read through and give it a +-1
> rating. When a commit reaches a given threshold, in it would go; if there
> were any merging conflicts, the submitter would be required to merge the code
> by hand. Context could be retained if every developer committed only
> discrete changes to the code; then each commit would be self-contained, and
> the system could look at each commit by a single developer as a chunk for
> review, regardless of how many files it modified. DIE, rather than fixing
> something, test it, fix something else, test it, and so on, and commit at the
> end of the day, you would fix something, test it, then commit it to your
> branch immediately, whereby the system would make it available for review.

Well, I think this would be an incredibly cool feature. If I have
the time, I'll help out in any way that I can. I know that this is
something we've kicked around in Apache httpd. I know that we have
had sporadic progress on something called "patchmaster" - basically,
the concept was to have a bunch of perl scripts to manage this,
but I really this could be better tied in with SVN itself. (And,
hey, SVN is an Apache module, so why not just extend mod_dav_svn
to encapsulate this as well?)

Anyone could make a commit to the tree (or perhaps they have to be
registered to prevent DoS, complete losers, etc) - it could then
trigger a notification or better yet have a page where *real*
committers can review submissions. They can then vote on it,
comment on it, or even cooler make modifications to the patch (and
inherently this is just revisions to this commit, so it can fit
within the SVN model nicely - meta-commits). And, as you've
suggested, once a configured amount of *real* committers have
approved it, the system can then merge it in. If the patch no
longer cleanly applies, then an email should be sent off to the
submitter (and possibly any committer who votes positively on it).
And, of course, once it is committed, the appropriate emails are
sent out.

In all, yes this is very cool and I want it too. =) -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:05 2006

This is an archived mail posted to the Subversion Dev mailing list.