Re: svn commit: rev 1186 - trunk/subversion/bindings/ruby

Greg Stein <gstein@lyra.org> writes:

> That isn't quite correct. svn_fs_close_fs() only clears/destroys a subpool.
> It will /not/ affect the pool that you passed in when you created the FS
> object. It is perfectly safe to call close_fs().
>
> > svn_repos_fs returns svn_fs_t * which lives in the same pool
> > of svn_repos_t *.
>
> No... the FS lives in a subpool. That subpool can be independently freed.

Ah, then this is the bug in svn_repos_open?

libsvn_repos/repos.c:

svn_error_t *
svn_repos_open (svn_repos_t **repos_p,
                const char *path,
                apr_pool_t *pool)
{
  apr_status_t apr_err;
  svn_repos_t *repos;

  /* Allocate a repository object. */
  repos = apr_pcalloc (pool, sizeof (*repos));
  repos->pool = pool;

  /* Initialize the repository paths. */
  repos->path = apr_pstrdup (pool, path);
  init_repos_dirs (repos, pool);
  
  /* Initialize the filesystem object. */
  repos->fs = svn_fs_new (pool);

-- 
Yoshiki Hayashi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org