[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] APR turn off readonly/executable, add apr_file_attrs_get

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-02-03 03:03:12 CET

Cliff Woolley <cliffwoolley@yahoo.com> writes:

> On Sat, 2 Feb 2002, Kevin Pilch-Bisson wrote:
>
> > On Sat, Feb 02, 2002 at 08:34:44PM +0000, Philip Martin wrote:
> > > +#ifdef APR_HAS_THREADS
> > > + status = apr_thread_mutex_lock(umask_mutex);
> > > + if (!APR_STATUS_IS_SUCCESS(status))
> > > + return status;
> > > +#endif
> >
> > Shouldn't this be
> > #if APR_HAS_THREADS
> >
> > i.e. isn't it always defined to either 0 or 1.
>
>
> Yes, it should be.

OK. I can make the mutex creation conditional as well.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:03 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.