[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue 619 APR patch, issue 532 read-only admin

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-01-31 23:48:56 CET

Philip Martin <philip@codematters.co.uk> writes:
> +#include "fileio.h"
> +#include "apr_file_io.h"
> +
> +static apr_status_t
> +apr_file_transfer_contents(const char *from_path,
> + const char *to_path,
> + apr_int32_t flags,
> + apr_fileperms_t to_perms,
> + apr_pool_t *pool)

If it's static, it probably shouldn't have the "apr_" prefix. Would
recommend a doc string however (I know APR isn't as strict about
enforcing this as Subversion is, but that doesn't mean they don't like
documentation too :-) ).

I haven't looked carefully at the rest of the patch yet. Suggestion:
since moving the apr_ functions over to APR is one change, and
addressing Subversion issue #532 is a separate change, post one small
patch for the former, and then post a second (dependent) patch for the
latter.

-Karl

> Issue #532: make files in the .svn admin area readonly.
>
> * subversion/include/svn_io.h
> (svn_io_copy_file): Add boolean permissions copying parameter.
> (svn_io_copy_dir_recursively): Add boolean permissions copying parameter.
> (svn_io_set_file_read_only): Add prototype.
>
> * subversion/libsvn_subr/io.c
> (apr_transfer_file_contents): Remove to APR.
> (apr_copy_file): Remove to APR.
> (apr_append_file): Remove to APR.
> (svn_io_copy_file): Call new APR function.
> (svn_io_append_file): Call new APR function.
> (svn_io_copy_dir_recursively): Pass new parameter to svn_io_copy_file and
> recursive svn_io_copy_dir_recursively.
> (svn_io_set_file_read_only): Add function.
>
> * subversion/libsvn_wc/adm_crawler.c
> (do_postfix_text_deltas, do_prop_deltas, restore_file): Pass new parameter
> to svn_io_copy_file.
>
> * subversion/libsvn_wc/adm_files.c
> (maybe_copy_file): Pass new parameter to svn_io_copy_file.
> (sync_adm_file): Use svn_io_set_file_read_only to make permanent adm file
> readonly.
> (close_adm_file): Use svn_io_set_file_read_only to make permanent adm file
> readonly.
>
> * subversion/libsvn_wc/copy.c
> (copy_file_administratively): Pass new parameter to svn_io_copy_file.
> (copy_dir_administratively): Pass new parameter to svn_io_copy_dir_recursively
>
> * subversion/libsvn_wc/get_editor.c (close_file): Add log entry to
> make text-base readonly.
>
> * subversion/libsvn_wc/log.c
> (replace_text_base): Pass new parameter to svn_io_copy_file.
> (log_do_file_readonly): New function.
> (start_handler): Handle SVN_WC__LOG_READONLY.
>
> * subversion/libsvn_wc/props.c (svn_wc__do_property_merge): Add log entries
> to make property files readonly.
>
> * subversion/libsvn_wc/translate.c (svn_wc_copy_and_translate): Pass new
> parameter to svn_io_copy_file.
>
> * subversion/libsvn_wc/wc.h
> (SVN_WC__LOG_READONLY): Add log tag.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:01 2006

This is an archived mail posted to the Subversion Dev mailing list.