[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #532 read-only admin area

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-01-28 23:00:30 CET

Philip Martin <philip@codematters.co.uk> writes:
> A resonable objection, sorry I missed your earlier comment. There
> doesn't however appear to be any APR support yet, nobody with Win32
> know-how has provided an implementation.
>
> I'll move the code in question into apr_file_set_read_only() in io.c
> like so

Even if no one has provided the Win32 know-how in APR yet, we could
still at least put the skeleton in place and have the Unix side done.
I think that would be better than adding a WIN32 conditional to
Subversion, considering that the minimal APR change here is so
trivial.

Philip, do you feel comfortable writing patches for APR? I imagine
that if you do enough of it, you'll wind up just committing directly
to APR before long anyway.

-K

> apr_status_t apr_file_set_read_only (const char *, apr_pool_t *)
> {
> #ifdef SVN_WIN32
> #else
> /* implementation in terms of apr_file_perms_set */
> #endif
> return APR_SUCCESS;
> }
>
> making the function effectively a no-op on Win32. Thus the admin area
> will become read-only on those platforms that are not SVN_WIN32 (which
> would have been the case anyway since apr_file_perms_set isn't
> implemented on Win32).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:00 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.