[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #532 read-only admin area

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-01-28 15:22:41 CET

On Mon, Jan 28, 2002 at 01:22:24PM +0000, Philip Martin wrote:
> "Sander Striker" <striker@apache.org> writes:
> > > - err = svn_io_copy_file (src->data, dst->data, pool);
> > > + err = svn_io_copy_file (src->data, dst->data, FALSE, pool);
> > > if (err)
> > > return err;
> >
> > Another one for SVN_ERR()
> Should we remove all occurrences of this construct? Trying
> $ for i in ../svn/subversion/libsvn_*/*c;do gawk '/if *\(err\)/{getline;if(/return *err/)print FILENAME":"NR}' $i;done
> gives me 92 places that might be changed.

i swept a bunch of them a little while ago... a bunch of the ones you
just caught are probably actually apr return values, not svn return
values. some of the old code uses "err" instead of "apr_err" for the
return value from apr functions. although i'm sure there are some
more svn ones lurking out there that we should clean up.


garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:00 2006

This is an archived mail posted to the Subversion Dev mailing list.