Re: svn commit: rev 1062 - trunk/subversion/clients/cmdline

On Fri, Jan 25, 2002 at 01:48:59PM -0600, Karl Fogel wrote:
> Greg Stein <gstein@lyra.org> writes:
> > You asked me once about APR_STATUS_IS_SUCCESS ...
> >
> > IMO, the macro is bogus. The other apr_errno macros are used to check the
> > status against multiple errors, based on the platform you're on. (e.g. a
> > file not found might have several possibilities on Windows)
> >
> > But there is only /one/ "success" code. So testing directly against
> > APR_SUCCESS is quite legal:
>
> Um... no?
>
> Looking in apr.h, I see that APR_STATUS_IS_SUCCESS() is *not* always
> defined as a simple test against zero.

Oh, yuck, that's such a bogus macro. No one else is paying attention
to that APR_OS_START_SYSERR + NO_ERROR case. (I can virtually
guarantee httpd-2.0 isn't paying attention. And, if it should be,
we have *lots* of problems.)

+1 for getting rid of that macro entirely. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:37:00 2006