[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] import_dir should close directory it opened

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-01-25 18:00:30 CET

Yoshiki Hayashi <yoshiki@xemacs.org> writes:
> I found this bug while investigating issue #602 (and this
> patch is attached to that issue).

Committed. Thanks for spotting this, Yoshiki! The bug was mine, by
the way, I remember writing that function.

-Karl

> The comment above import_dir says calling
> EDITOR->close_directory(DIR_BATON) is the caller's job.
> Now, import_dir calls import_dir recursively. It needs to
> close directories it opened.
>
> * commit.c (import_dir): Call close_directory for directories you opened.
>
> Index: ./subversion/libsvn_client/commit.c
> ===================================================================
> --- ./subversion/libsvn_client/commit.c
> +++ ./subversion/libsvn_client/commit.c Thu Jan 24 00:27:09 2002
> @@ -197,6 +197,7 @@
>
> /* Recurse. */
> SVN_ERR (import_dir (editor, this_dir_baton, new_path, subpool));
> + SVN_ERR (editor->close_directory (this_dir_baton));
> }
> else if (this_entry.filetype == APR_REG)
> {
>
>
> --
> Yoshiki Hayashi
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:59 2006

This is an archived mail posted to the Subversion Dev mailing list.