Re: [PATCH] Trace editor should free dir_baton when it's done.
* Branko ??ibej (email@example.com) wrote :
> I don't see anything wrong with this patch. The idea is definitely sound.
> Needs another pair of eyes, but on the whole I recommend we commit it.
> Yoshiki Hayashi wrote:
> >Implement freeing directory button using reference counting.
> >* trace-commit.c
> >(add_directory): Create subpool. Initialize refcount. Increment parent's
> > refcount.
> >(open_directory): Ditto.
> >(close_directory): Call decrement_dir_ref_count.
> >(clsoe_file): Ditto.
as an unfeasibly tiny niggle, I guess this typo should be fixed before the
-Thom, easing into svn _very_ gradually ;-)
Received on Sat Oct 21 14:36:59 2006
- application/pgp-signature attachment: stored
This is an archived mail posted to the Subversion Dev