[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Trace editor should free dir_baton when it's done.

From: Thom May <thom_at_planetarytramp.net>
Date: 2002-01-25 00:19:04 CET

* Branko ??ibej (brane@xbc.nu) wrote :
> I don't see anything wrong with this patch. The idea is definitely sound.
> Needs another pair of eyes, but on the whole I recommend we commit it.
>
> Yoshiki Hayashi wrote:
[...]
>
> >
> >Implement freeing directory button using reference counting.
> >* trace-commit.c
> >
[...]
> >(add_directory): Create subpool. Initialize refcount. Increment parent's
> > refcount.
> >(open_directory): Ditto.
> >(close_directory): Call decrement_dir_ref_count.
> >(clsoe_file): Ditto.
      ^^^^
as an unfeasibly tiny niggle, I guess this typo should be fixed before the
commit...

-Thom, easing into svn _very_ gradually ;-)

  • application/pgp-signature attachment: stored
Received on Sat Oct 21 14:36:59 2006

This is an archived mail posted to the Subversion Dev mailing list.