Sounds good overall, just one quick comment:
> A few inlined questions follow.
>
> I've implemented a couple of things that can be considered issue #604 stuff
> or closely related. My hope is that we can concentrate on this CVS-mimic
> behavior first, and then possibly start adding more fancy features when this
> is done and committed.
>
> It currenly does this:
>
[...]
> * If the edited file has the same size and modification time after the
> editor is closed, a prompt will appear asking if the user wants to:
> abort, continue or edit the message again. abort means aborting the
> commit, continue means commit with empty message and edit will fire up
> the editor again.
>
I would prefer if it also always gave these options if the log message was
empty after being stripped (or possibly had an empty diff with respect to
the version before editing). I been bitten before by this in CVS. I started
a commit and realized I needed to make one more change before committing after
I had started to write a commit message after I had already saved the message
(I save compulsively) but before I had exited the editor. I tried to edit
the message to be empty so that it would give me the abort option (since I've
found it tricky to abort any other way) and was upset to see if go ahead
and commit my changes with an empty log message thus robbing those files of
the correct log message. I think it should be easy for the user to figure
out when the choices will be given and possible to always get the abort choice
if you really want it.
Just my 2 cents. Keep up the good work.
- Scott Lenser
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:59 2006