Re: raises hand for bite-sized issue #604

On Tue, Jan 22, 2002 at 02:24:45PM -0500, Mark Benedetto King wrote:
 
> > As for ideas, the only thing I really want is for the default message
> > to start with a list of files changed in the format we currently use.
> > Something like this:
> >
> > * subversion/foo/bar.c
> > * subversion/includes/bar.h
> >
>
> One thing that I remember perforce doing right:
>
> It noticed when you deleted items from the changed-file-list. That way
> you could easily commit some, but not all, of your changes. A potentially
> unsafe practice, but handy nonetheless.

annother thing perforce does wrong with regard to this, just for the
record.

the parser for their commit log form is notoriously picky. all lines
that you add have to start with a tab, or it will not commit. this
annoys the hell out of me, and if we're going to parse the commit
message to do something with it, i suggest avoiding that kind of
behavior.

in any event, i don't think we should be parsing the list of files and
changing behavior based on them. we have the command line to do that,
and having multiple places to change the behavior just seems like an
interface mistake. plus, it ties us to one format for the log
messages, and i don't think we should be doing that. if a project
doesn't want their logs to have the files listed, it shouldn't have to,
and if we're parsing the file looking for that, how do we know if they
just decided no to have that, or if they deleted all the lines? it's
just ugly.

so just say no to parsing the commit logs...

-garrett

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org