[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

problem with xml tests

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-01-21 20:29:28 CET

since the changes to support builddir != srcdir in the tests,
svn-test.sh and svn-test2.sh have been giving me errors. they still
succeeded, but the shell scripts weren't entirely correct.

i just got a chance to look closer, and it turns out they are passing
the '==' operator to [, which is not a valid operator on FreeBSD. to
be portable, we should be using =, not ==.

here's a patch.

-garrett

*subversion/tests/clients/cmdline/xmltests/svn-test.sh
  use = instead of == with [.
*subversion/tests/clients/cmdline/xmltests/svn-test2.sh
  ditto.

Index: subversion/tests/clients/cmdline/xmltests/svn-test.sh
===================================================================
--- subversion/tests/clients/cmdline/xmltests/svn-test.sh
+++ subversion/tests/clients/cmdline/xmltests/svn-test.sh Mon Jan 21 14:18:00 2002
@@ -2,13 +2,13 @@
 
 SVN_PROG=../../../../clients/cmdline/svn
 XML_DIR=../../../xml
-if [ "x${1}" == "x" ]; then
+if [ "x${1}" = "x" ]; then
     SVN_PROG=$(pwd)/${SVN_PROG}
 else
     # argument passed by make when builddir != srcdir
     SVN_PROG=${1}/${SVN_PROG}
 fi
-if [ "x${2}" == "x" ]; then
+if [ "x${2}" = "x" ]; then
     XML_DIR=$(pwd)/${XML_DIR}
 else
     # argument passed by make when builddir != srcdir
Index: subversion/tests/clients/cmdline/xmltests/svn-test2.sh
===================================================================
--- subversion/tests/clients/cmdline/xmltests/svn-test2.sh
+++ subversion/tests/clients/cmdline/xmltests/svn-test2.sh Mon Jan 21 14:18:25 2002
@@ -4,13 +4,13 @@
 
 SVN_PROG=../../../../clients/cmdline/svn
 XML_DIR=../../../xml
-if [ "x${1}" == "x" ]; then
+if [ "x${1}" = "x" ]; then
     SVN_PROG=$(pwd)/${SVN_PROG}
 else
     # argument passed by make when builddir != srcdir
     SVN_PROG=${1}/${SVN_PROG}
 fi
-if [ "x${2}" == "x" ]; then
+if [ "x${2}" = "x" ]; then
     XML_DIR=$(pwd)/${XML_DIR}
 else
     # argument passed by make when builddir != srcdir

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:57 2006

This is an archived mail posted to the Subversion Dev mailing list.