[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: path canonicalization problem (issue #559)

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-01-21 18:37:50 CET

Great, thanks Garrett! I've left issue #559 assigned to Branko;
recommend discussing with him whatever solution you come up with, it
seems that he's thought about this a lot and will have useful things
to say, no matter who writes the code.

Note that issue #559 is not about duplicate slashes within the string,
but about stripping trailing slash(es) from the end of the string.
Maybe we'll want to change one behavior and not the other, or maybe
both, but in any case, the specific badness referred to in the issue
results from stripping trailing slashes.

-Karl

Garrett Rooney <rooneg@electricjellyfish.net> writes:
> On Sun, Jan 20, 2002 at 09:55:23AM -0600, cmpilato@collab.net wrote:
> > I don't know if it's a *good* solution, but svn_path_canonicalize
> > could start calling svn_path_is_url() (which itself can use some
> > maturing) to test for URL-ness. Once URL-ness is discovered, the
> > simple rule could be that we will never remove any of the first three
> > '/'s in the path:
> >
> > <scheme>://<optional_server>/path/on/server
> > | |
> > +------- "safe zone" -------+
>
> well, it's certainly a solution, and it's a hell of a lot easier than
> changing all of our url's in the tree to use a separate url type.
>
> if i get bored today i'll look at implementing it that way and see if
> anything breaks.
>
> -garrett
>
> --
> garrett rooney Unix was not designed to stop you from
> rooneg@electricjellyfish.net doing stupid things, because that would
> http://electricjellyfish.net/ stop you from doing clever things.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:57 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.