[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for issue #591

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2002-01-21 03:48:25 CET

On Sun, Jan 20, 2002 at 06:48:31PM -0800, Greg Stein wrote:
> On Sun, Jan 20, 2002 at 12:35:44PM -0500, Garrett Rooney wrote:
> > here's a fix for issue #591 (svn cp URLfile localpath doesn't preserve
> > properties).
> >
> > -garrett
> >
> > When copying a file from the repository to the working copy, preserve
> > any properties the file had set on it. This fixes issue $591.
>
> The basic structure of the patch is good, but the set of properties returned
> needs to be fixed up. Specifically, it is missing the "entry" properties,
> and it is missing some wcprops.
>
> The problem with getting that stuff in there is that the RA and WC property
> story is very unclean right now. I would recommend committing this (i.e. +1)
> and then we can revamp the property story, and include this in that revamp.
>
> (well, +1 with the cast fixes that have been discussed)

in that case, i will commit it. should i also close issue 591? or
should that wait until those cleanups are done?

-garrett

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:57 2006

This is an archived mail posted to the Subversion Dev mailing list.