On Fri, Jan 11, 2002 at 03:00:45PM +0000, Philip Martin wrote:
> Greg Stein <gstein@lyra.org> writes:
>
> > Let's make a utility function for this.
> >
> > I would recommend using APR's APR_DELONCLOSE flag for these files so that we
> > can make sure they go away. That would obviate the need for apr_file_remove
> > and being careful with exit branches (which Philip noted).
>
> The problem with APR_DELONCLOSE is that (on Unix at least) the file
> gets unliked just after creation and so cannot be passed to an
> external diff program. Pool cleanup handlers can be used (and diff
Actually, that is an incorrect statement. APR_DELONCLOSE does
exactly what it says - it only unlinks the file when the pool
is cleaned up or the file is closed. So, perhaps this *is* the
right solution? The file should still be around as long as it
hasn't been cleaned up.
Cliff Woolley made this change in rev 1.86 of file_io/unix/open.c
to be consistent with Win32. We all thought that this was the
right way anyway.
I don't know how this affects your thinking for this issue, but I
thought it might be useful to point it out. -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006