Re: svn commit: rev 834 - trunk/subversion/libsvn_wc

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> Greg Stein <gstein@lyra.org> writes:
> > The above block is effectively duplicated twice in this file. I seem to
> > recall that another checkin (from Karl?) just occurred with basically the
> > same code. Ah yes... in questions.c.
> >
> > Let's make a utility function for this.
>
> That's what we're doing (see upcoming checkins).
>
> > I would recommend using APR's APR_DELONCLOSE flag for these files so that we
> > can make sure they go away. That would obviate the need for apr_file_remove
> > and being careful with exit branches (which Philip noted).
>
> The files are opened, closed immediately, then opened later, written
> to, then closed and removed. The second close could use DELONCLOSE,
> yeah!

No. APR_DELONCLOSE unlinks the file. The path cannot then be passed to
an external process.

I suggest modifying svn_io_open_unique_file() to have a flag that
causes it to install an apr pool plain cleanup handler to remove the
file, and an apr pool child cleanup handler to remove the plain
cleanup handler. Then the files will disappear with the pool and not
before.

-- 
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org