[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 828 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/bindings/ruby trunk/subversion/clients/cmdline

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-01-11 06:02:22 CET

Greg Stein <gstein@lyra.org> writes:
> Note the svn_boolean_t type.
>
> >...
> > +++ NEW/trunk/subversion/libsvn_wc/diff.c Thu Jan 10 22:24:17 2002
> > @@ -303,7 +303,7 @@
> > break;
> >
> > default:
> > - SVN_ERR (svn_wc_text_modified_p (&modified, path, dir_baton->pool));
> > + SVN_ERR (svn_wc_text_modified_p (&modified, path, 1, dir_baton->pool));
>
> So why use "1" rather than TRUE / FALSE throughout?

I used 1 to avoid having to put an extra line break in one of the
calls (would have gone over 80 cols).

I'm completely serious. :-)

That whole change got reverted, though, probably while you were still
reviewing it (sorry!). I misjudged the abstraction I needed by a
smidgen, sigh.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:56 2006

This is an archived mail posted to the Subversion Dev mailing list.