[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] fix core and make tests pass

From: Craig Peterein <craig.peterein_at_myrealbox.com>
Date: 2002-01-05 13:59:10 CET

The following tests failed:

$ make check
...
Running all tests in svn-test2.sh...svn-test2.sh: line 148: 8242 Segmentation fault ${SVN_PROG} commit --xml-file ${COMMIT_RESULTFILE_NAME}-1.xml --revision 24 ${TEST_DIR_1} --message "24 slices of American cheese"
Running all tests in svn-test.sh...svn-test.sh: line 80: 8338 Segmentation fault ../${SVN_PROG} commit --xml-file ../${COMMIT_RESULTFILE_NAME}-2.xml --revision 2
...

Here's the relevant parts of tests.log:

Attempting to commit again, with conflicts removed.
Oops, problem: 15
END: svn-test2.sh

Committing changes in t1.
Oops, problem: 6
END: svn-test.sh

and the backtrace:

#0 0x402ed486 in apr_pstrdup (a=0x8055b30, s=0x6 <Address 0x6 out of bounds>) at apr_strings.c:79
#1 0x4001c92e in send_to_repos (committed_rev=0xbffff470, committed_date=0xbffff46c, committed_author=0xbffff468, before_editor=0x0,
    before_edit_baton=0x0, after_editor=0x8057920, after_edit_baton=0x8057918, base_dir=0x8057a70, condensed_targets=0x8057a80, url=0x0,
    new_entry=0x0, auth_baton=0x8055d58, log_msg=0x0, xml_dst=0x8055d10, revision=2, pool=0x8055b30) at subversion/libsvn_client/commit.c:631
#2 0x4001caf9 in svn_client_commit (committed_rev=0xbffff470, committed_date=0xbffff46c, committed_author=0xbffff468, before_editor=0x0,
    before_edit_baton=0x0, after_editor=0x8057920, after_edit_baton=0x8057918, auth_baton=0x8055d58, targets=0x8055d28, log_msg=0x0,
    xml_dst=0x8055d10, revision=2, pool=0x8055b30) at subversion/libsvn_client/commit.c:728
#3 0x0804a09b in svn_cl__commit (os=0x8055cb0, opt_state=0xbffff4d0, pool=0x8055b30) at subversion/clients/cmdline/commit-cmd.c:110
#4 0x0804cf9f in main (argc=6, argv=0xbffff5b4) at subversion/clients/cmdline/main.c:610
#5 0x403b965f in __libc_start_main () from /lib/libc.so.6

 * commit-cmd.c (svn_cl__commit): Initialize date and author to NULL to prevent
 core and make tests pass (svn-test.sh and svn-test2.sh)

Index: ./subversion/clients/cmdline/commit-cmd.c
===================================================================
--- ./subversion/clients/cmdline/.svn/text-base/commit-cmd.c.svn-base Thu Jan 3 19:58:34 2002
+++ ./subversion/clients/cmdline/commit-cmd.c Sat Jan 5 06:34:53 2002
@@ -52,6 +52,8 @@
   const char *date; /* Server-side date of the commit. */
   const char *author; /* Server-side author of the commit. */
 
+ date = NULL;
+ author = NULL;
   /* Take our message from ARGV or a FILE */
   if (opt_state->filedata)
     message = opt_state->filedata;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:54 2006

This is an archived mail posted to the Subversion Dev mailing list.