Re: "nasty chmod hack" patch

On 21 Dec 2001 12:24:30 -0600
cmpilato@collab.net wrote:

> Mo, I decided to keep the chmod a+x in Makefile.in until we have the
> ability to version the execute perm bit. Once we can do that, we'll
> simply commit that perm prop on those scripts and then remove the
> chmod hack. The rest of the patch was all good, though, and was left
> untouched.

There is no reason to keep the chmod hack. The reason it was in there
before was to add execute perms to a shell script, but the patch runs
a shell script using $(SHELL) instead of executing it:

runprog="$(SHELL) $$progbase"

The chmods in autogen.sh could go away once the execute perms are
under revision control, but it should not matter for Makefile.in. Also,
the source code might be on a read only media (like a CD) so running
a chmod on the shell scripts at "make check" time would produce an error.

cheers
Mo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:53 2006