[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: line-ending conversion and keyword substitution

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2001-12-11 20:43:56 CET

Greg Hudson <ghudson@MIT.EDU> writes:
> Actually, no, this proposal doesn't satisfy my principle, because you
> are transforming file contents before checkins. (I'm okay with
> transformation after checkin on what's in the working directory; that's
> necessary for keyword substitution.)

I reread Ben's document, and your paragraph, and I'm still not
understanding the problem. Sorry, could you be more verbose?

> Your reason for wanting pre-commit transformation is that you want to
> have a uniform line ending style in the repository across all versions
> of a file. The consequences of this decision are two-fold:
>
> 1. The repository diffs become smaller because you don't have gratuitous
> newline diffs every time a Windows developer checks in the file after a
> Unix developer did and vice versa.
>
> 2. If you accidentally commit a binary file with newline substitution
> turned on, you irrevocably destroy the contents of the file.
>
> I don't think that's a very good tradeoff, at least for a feature which
> is on by default (for files we think are text files).

I think if we do it at all, we're now leaning toward off by default,
so that danger is pretty much avoided.

Greg, it might actually be most helpful if you'd describe your ideal
newline conversion system, in detail and without reference to any of
the other proposals. (Or have done this before, and I'm just not
finding the post?)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:52 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.