[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: more non constants in struct initializers.

From: <cmpilato_at_collab.net>
Date: 2001-12-05 16:56:30 CET

Max Okumoto <okumoto@ucsd.edu> writes:

> * subversion/libsvn_ra_local/commit_editor.c
> Fixed non constants in struct initializers.
>
> * subversion/subversion/tests/libsvn_repos/dir-delta-editor.c
> Fixed non constants in struct initializers.

and:

> * subversion/subversion/libsvn_ra_dav/commit.c
> static const int variable needs init value even if it is zero.

--
I'm about to commit these patches, for which I certainly thank you.
However, I must ask that in the future you include the symbol names of
the function, global var, struct, prototype, etc. that was modified.
3 lines of context typically won't provide that info to a reviewer,
and more importantly, if it isn't in the log message, 'svn log'
because rather useless.  I've added this information for these 2 (and
your previous 3) patches, but have to ask that in the future you save
me that step.  Thanks, Max.
Side note:  Ben and I were wondering if you were using some sort of
code profiling tool to find those memory leaks, or what?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:51 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.