[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: mem leaks in svn_ra_dav__get_baseline_info()

From: Max Okumoto <okumoto_at_ucsd.edu>
Date: 2001-12-04 13:08:55 CET

> Found a leak in svn_ra_dav__get_baseline_info()
>
> When the 'url' is parsed with uri_parse(), the
> variable 'parsed_url' has strings allocated via ne_strdup()
>
> The strings are lost when the function returns.

* subversion/libsvn_ra_dav/props.c
  Free parsed uri strings as soon as possible.

Index: subversion/libsvn_ra_dav/props.c
===================================================================
--- subversion/libsvn_ra_dav/.svn/text-base/props.c.svn-base Sun Dec 2 13:34:41 2001
+++ subversion/libsvn_ra_dav/props.c Tue Dec 4 04:05:41 2001
@@ -497,6 +500,7 @@
      ### and omit relpath when bc_relative is NULL. */
   SVN_ERR( svn_ra_dav__get_props_resource(&rsrc, sess, parsed_url.path,
                                           NULL, starting_props, pool) );
+ uri_free(&parsed_url);
 
   if (is_dir != NULL)
     *is_dir = rsrc->is_collection;

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:51 2006

This is an archived mail posted to the Subversion Dev mailing list.