Re: svn commit: rev 461 - trunk/subversion/libsvn_wc

On Thu, Nov 15, 2001 at 01:21:04PM -0800, Greg Stein wrote:
> Looks good overall, although a lot of extra work is being done rather than
> using features of the existing functions.
>
> Also: it appears that the wcprops did not get the extension added to them. I
> haven't looked into the code, but I still have ".svn/wcprops/foo.c" in my
> working copy. So they still appear in a "find" :-)

Well I only did the base-props, so if there was a file with regular props on
it, it would still show up in the props directory. I guess that will be
another wc busting commit. :)
>
> And I apologize for not reviewing the patch beforehand. I would have seen
> the comments below:
>
> On Thu, Nov 15, 2001 at 12:26:46PM -0600, kevin@tigris.org wrote:
> >...
> > --- OLD/trunk/subversion/libsvn_wc/props.c Thu Nov 15 12:26:44 2001
> > +++ NEW/trunk/subversion/libsvn_wc/props.c Thu Nov 15 12:26:44 2001
> >...
> > @@ -625,12 +625,14 @@
> > SVN_WC__ADM_PROP_BASE,
> > name->data,
> > NULL);
> > + svn_stringbuf_appendcstr(tmp_prop_base, SVN_WC__BASE_EXT);
> > real_prop_base = svn_wc__adm_path (svn_stringbuf_create ("", pool),
> > 0, /* no tmp */
> > pool,
> > SVN_WC__ADM_PROP_BASE,
> > name->data,
> > NULL);
> > + svn_stringbuf_appendcstr(real_prop_base, SVN_WC__BASE_EXT);
>
> The above two chunks of code would be simplified by simply placing
> SVN_WC__BASE_EXT directly into the svn_wc__adm_path() call. No need for a
> second function call to append the extension.

Not quite. The problem is that it makes a string of the form:

.svn/[tmp/]va_arg1/va_arg2/.../path

using svn_path_add_component, and always with the args before the given path.

There is no way to add something to the end of the path (with the existing
extend_with_adm_name, sync_adm_file, etc). That was what I did first, then
I went to test it out, and was getting messed up paths. Maybe what I should
have done was make the functions take an 'is_base' are, similar to 'tmp' arg,
and paste it on if the arg was true. Wouldn't be that hard to do if people
think it is better. In fact, it might be if we want to add an extension to
non-base props files as well (which we should).

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~