[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Outstanding Patches.

From: Mo DeJong <supermo_at_bayarea.net>
Date: 2001-10-29 01:46:42 CET

On 28 Oct 2001 22:58:35 +0000
Philip Martin <philip_martin@ntlworld.com> wrote:

> Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
>
> > 3) svn diff showing added files, from Mo Dejong. I promised to look at this
> > and I'm still trying to think of a cleaner way to do it than to create
> > hit the disk three times per added file.
>
> The patch worked by creating a temporary, empty file for the diff
> command, when the svn_wc_get_pristine_copy_path() failed to open a
> cached version. Now all empty files are identical, so the wc layer
> could create an empty file once and retain it for future use. Then
> svn_wc_get_pristine_copy_path() could return a path to the single
> empty file without the overhead of any file creation calls.
>
> Philip

This seems like an early optimization. The time needed to touch an
empty file seems like nothing compared to creating a new process
and running diff. We might also just create an empty foo.c in the
pristine dir when `svn add foo.c` is run. It seems like getting the feature
implemented and tested is more important than this minor impl detail.

Mo DeJong

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:46 2006

This is an archived mail posted to the Subversion Dev mailing list.