Re: svn commit: rev 300 - trunk/subversion/include trunk/subversion/libsvn_subr trunk/subversion/tests/libsvn_subr

Branko Čibej <brane@xbc.nu> writes:
> This produces three new warnings on Windows:
>
> C:\Home\brane\src\svn\repo\subversion\libsvn_subr\path.c(544) : warning C4018: '<' : signed/unsigned mismatch
> C:\Home\brane\src\svn\repo\subversion\libsvn_subr\path.c(563) : warning C4018: '<' : signed/unsigned mismatch
> C:\Home\brane\src\svn\repo\subversion\libsvn_subr\path.c(609) : warning C4018: '<' : signed/unsigned mismatch
>
> Again, it's because you're comparing an int with a
> svn_string_t::len. This is rather a bore.
>
> Please, let's decide once and for all what we'll do about this. Either
> make svn_string_t::len an int, or use apr_size_t for induction
> variables in loops that traverse a string. My vote is for the second
> option.

+1

There's no reason to have a sign on a string index variable. Let's
use apr_size_t.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:45 2006