RE: Compile warnings on Win32

>Could you post a repro for this? Just looking at your temporary fix
>doesn't help me understand the problem.

When you execute the import cmd, e.g.
svn import file:///apache_1.3/htdocs/newrepos c:\backup bak1

you get an error:
apr_error: #20508, src_err 0 : <The input data is incomplete>
  error during import of `c:\backup'

I tracked the error down to import_dir and noticed the similarity with
an earlier problem in apache 2.16.
apr_dir_read (&this_entry, APR_FINFO_NORM, dir) sometimes fails down in
win32/filestat.c:more_finfo

The import seems to work successfuly with the temporary code change to
import_dir:
  for (apr_err = apr_dir_read (&this_entry, APR_FINFO_NORM, dir);
       //APR_STATUS_IS_SUCCESS (apr_err); //mpg
                apr_err != 22518;
       apr_err = apr_dir_read (&this_entry, APR_FINFO_NORM, dir))
    {

This traverses the file list successfully until there are no more
entries. Another fix would be to use
apr_err = apr_dir_read (&this_entry, 0, dir).

I don't understand the code well enough to suggest a permanent solution.
However, it does not seem like this_entry is used for anything other
than the filename and filetype.

I agree on not disabling that particular compiler warning. On the
surface it looks like automatic conversion from __int64 to shorter data
types is not appropriate.

--Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:44 2006