On Wed, Sep 19, 2001 at 06:58:10PM -0400, Kevin Pilch-Bisson wrote:
> On Wed, Sep 19, 2001 at 06:03:49PM -0400, Garrett Rooney wrote:
> > it appears that we've got several places where we're either passing a
> > url to svn_path_canonicalize with style = svn_path_repos_style or we're
> > passing a path to svn_path_canonicalize with style =
> > svn_path_url_style, so if we're basing our behavior on the style,
> > we'll have to make this more consistent in the rest of the tree.
>
> Those are definitely things we want to fix. If you would point them out, it
> would be great. It's currently breaking some stuff on Win32.
problem spots i've tracked down so far...
in subversion/clients/cmdline/util.c:snv_cl__args_to_target_array
we're calling it with svn_path_local_style when at least sometimes
(perhaps all the time, i'm not sure) it gets passed an array. right
now i've changed it to svn_path_url_style, but i think we may also be
passing some paths in, so it may only be working because i've got / as
my dirsep char.
in subversion/libsvn_ra_dav/fetch.c:we're passing in
svn_path_url_style when at least sometimes we're giving it a path.
i've changed it to svn_path_local_style and it seems to work fine now.
i suspect there could be other places there are similar problems, but
i haven't been able to test everything yet... got sidetracked by
import problems. also i'm probably masking some more cases of giving
a path and using svn_path_url_style, because my svn_path_canonicalize
function now recovers from that case (if strstr (path->data, "//")
returns null it just assumes you gave it a path). this is making it
work (at least for checkout and update so far) but it's wrong and will
fail on windows...
isn't path handling fun!
-garrett
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:42 2006