[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: MODIFIED: libsvn_ra_dav ...

From: <kfogel_at_collab.net>
Date: 2001-08-14 18:06:28 CEST

gstein@tigris.org writes:
> +
> + /* use custom prefix for anything that doesn't start with "svn:" */
> + if (strncmp(name, "svn:", 4) == 0)
> + ne_buffer_concat(body, "<S:", name + 4, ">", value, "</S:", name + 4, ">",
> + NULL);
> + else
> + ne_buffer_concat(body, "<C:", name, ">", value, "</C:", name, ">", NULL);
> +
> return 1;
> }

Greg, should we worry about the case where name < 4 bytes long? It
seems to me the strncmp() might run off the end, then.

> + const char *name = APR_ARRAY_IDX(rb->prop_deletes, n, const char *);
> +
> + /* use custom prefix for anything that doesn't start with "svn:" */
> + if (strncmp(name, "svn:", 4) == 0)
> + ne_buffer_concat(body, "<S:", name + 4, "/>", NULL);
> + else
> + ne_buffer_concat(body, "<C:", name, "/>", NULL);
> }

Same question here, of course.

?,
-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:36 2006

This is an archived mail posted to the Subversion Dev mailing list.