[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Tiny tweak for error checking in fs.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-05-10 19:00:50 CEST

On Thu, May 10, 2001 at 09:41:02AM -0700, Bill Tutt wrote:
> While running repos_test for a 2nd time, the repository creation failed
> because the status check against APR_ENOENT didn't match what the APR
> code returned.
>
> It appears that APR wants folks to use the APR_STATUS_IS_E....() macros
> in order to perform this check.

True.

> The Win32 definition of the macro also
> has a bug, it's missing the very error code that is returned from
> apr_dir_read() here.

Supply a patch and I can commit it :-)

> Ok to commit?

Sure!

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:30 2006

This is an archived mail posted to the Subversion Dev mailing list.