[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_wc entries.c

From: Ben Collins-Sussman <sussman_at_newt.ch.collab.net.apple.com>
Date: 2001-04-03 00:37:27 CEST

kevin@tigris.org writes:

> svn_client_add (svn_string_t *path, apr_pool_t *pool)
> {
>
>...
> + if (err)
> + {
> + if (err->apr_err == SVN_ERR_WC_ENTRY_EXISTS)
> + svn_handle_warning(err, "svn warning: Cannot add
>because \"%s\"", err->message);

Oops... svn_handle_warning() calls printf(). It's not suitable for
use in libsvn_client... only suitable for the actual command line
client. Instead, you should change this to svn_error_quick_wrap to
return a more descriptive message "wrapped" around the real message.
When the command-line client receives it, it will print all the layers
of the error.
Received on Sat Oct 21 14:36:27 2006

This is an archived mail posted to the Subversion Dev mailing list.