Re: CVS update: subversion/subversion/libsvn_wc adm_ops.c

Greg Stein <gstein@lyra.org> writes:
> > + Eventually, the "track" editor's close_edit() routine needs to call
> > + this too, for those times when it's specifically comingled with the
> > + XML-output editor. (svn_wc_close_commit and its helpers will then
> > + be deprecated!) */
>
> Why does the track editor need to do anything? From the comment above, it
> sounds like there is a special case in the track editor for when it is
> combined with the XML editor? That's not cool...

It's just the comment that's innaccurate (I know this because Ben and
Mike and I were talking about this in depth today).

What's really going on is, the track editor behaves specially when
it's told to do revision bumping itself -- and the only time we know
of when it does that is when one is committing to an XML file during a
test run (for example).

But the track editor is not sensitive to which editor(s) it's composed
with, that would indeed be badness. It is sensitive to the arguments
it was obtained with, as it should be (or soon will be).

-K
Received on Sat Oct 21 14:36:25 2006