This is a good example of why I include filenames in my log messages.
When I read the header text here, I expected to find a function
txn_body_clone_root in dag.c.
kfogel@tigris.org writes:
>
> User: kfogel
> Date: 01/02/20 13:10:20
>
> Modified: subversion/libsvn_fs dag.c editor.c node-rev.h
> Log:
> (txn_body_clone_root): New name for clone_root, same motivation as
> similar recent change.
>
> Also, added some comments about possibly missing functionality.
>
> Revision Changes Path
> 1.18 +2 -0 subversion/subversion/libsvn_fs/dag.c
>
> Index: dag.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_fs/dag.c,v
> retrieving revision 1.17
> retrieving revision 1.18
> diff -u -r1.17 -r1.18
> --- dag.c 2001/02/15 19:00:00 1.17
> +++ dag.c 2001/02/20 21:10:20 1.18
> @@ -178,6 +178,8 @@
>
> /* With its Y-chromosome changed to X
> (Create the new, mutable root node.) */
> + /* kff todo: put_representation_skel doesn't seem to do anything
> + with mutability yet... */
> err = svn_fs__create_successor
> (&root_id, fs, base_root_id, base_skel, trail);
> if (err)
>
>
>
> 1.11 +20 -2 subversion/subversion/libsvn_fs/editor.c
>
> Index: editor.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_fs/editor.c,v
> retrieving revision 1.10
> retrieving revision 1.11
> diff -u -r1.10 -r1.11
> --- editor.c 2001/02/20 20:15:09 1.10
> +++ editor.c 2001/02/20 21:10:20 1.11
> @@ -80,7 +80,7 @@
>
> /* Helper for replace_root. */
> static svn_error_t *
> -clone_root (void *dir_baton, trail_t *trail)
> +txn_body_clone_root (void *dir_baton, trail_t *trail)
> {
> struct dir_baton *dirb = dir_baton;
> svn_error_t *err;
> @@ -140,7 +140,7 @@
> dirb->parent = NULL;
> dirb->name = svn_string_create ("", eb->pool);
> dirb->base_rev = eb->base_rev;
> - err = svn_fs__retry_txn (eb->fs, clone_root, dirb, eb->pool);
> + err = svn_fs__retry_txn (eb->fs, txn_body_clone_root, dirb, eb->pool);
> if (err)
> return err;
>
> @@ -257,7 +257,22 @@
> }
>
>
> +struct replace_args
> +{
> + fooo;
> +};
> +
> static svn_error_t *
> +txn_body_replace (void *rargs, trail_t *trail)
> +{
> + struct replace_args *repl_args = rargs;
> +
> +
> +
> + return SVN_NO_ERROR;
> +}
> +
> +static svn_error_t *
> replace_directory (svn_string_t *name,
> void *parent_baton,
> svn_revnum_t base_revision,
> @@ -269,6 +284,9 @@
> dirb->parent = pb;
> dirb->edit_baton = pb->edit_baton;
> dirb->name = svn_string_dup (name, pb->edit_baton->pool);
> +
> +
> + fooo;
>
> *child_baton = dirb;
> return SVN_NO_ERROR;
>
>
>
> 1.5 +4 -0 subversion/subversion/libsvn_fs/node-rev.h
>
> Index: node-rev.h
> ===================================================================
> RCS file: /cvs/subversion/subversion/libsvn_fs/node-rev.h,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- node-rev.h 2001/02/12 00:26:14 1.4
> +++ node-rev.h 2001/02/20 21:10:20 1.5
> @@ -58,6 +58,10 @@
> *NEW_ID_P to the new node revision's ID. Use TRAIL->pool for any
> temporary allocation.
>
> + kff todo: I think the mutability part might be a lie.
> + put_representation_skel() doesn't seem to do anything with
> + mutability yet... Must check into this.
> +
> After this call, the deltification code assumes that the new node's
> contents will change frequently. */
> svn_error_t *svn_fs__create_successor (svn_fs_id_t **new_id_p,
>
>
>
>
Received on Sat Oct 21 14:36:22 2006