Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
> Any reason we didn't move the client tests to the tests directory?
Yes. The command-line client test suite is just a shell script that
runs the client binary -- it doesn't link against the testing
framework, and it's convenient (development-wise) to have it right
there in a subdirectory. Later, when we are much less frequently
tweaking those tests and running them during development, I think it
will make sense to move them into the generic test location anyway,
but at the moment it doesn't seem worthwhile. (Perhaps the same could
have been said for the fs tests, but one difference is that the fs
tests *do* link against the test framework.)
On a semi-related note, someday the client/ directory will be moved to
clients/command-line or something similar, to bring it in line with
the other clients.
-K
> On Tue, Jan 30, 2001 at 11:23:40PM -0000, kfogel@tigris.org wrote:
> > User: kfogel =20
> > Date: 01/01/30 15:23:40
> >=20
> > Modified: subversion/client/tests Makefile.am
> > Log:
> > (check): It's "tests", not "tests-common".
> > =20
> > Revision Changes Path
> > 1.4 +2 -2 subversion/subversion/client/tests/Makefile.am
> > =20
> > Index: Makefile.am
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> > RCS file: /cvs/subversion/subversion/client/tests/Makefile.am,v
> > retrieving revision 1.3
> > retrieving revision 1.4
> > diff -u -r1.3 -r1.4
> > --- Makefile.am 2001/01/25 03:41:08 1.3
> > +++ Makefile.am 2001/01/30 23:23:40 1.4
> > @@ -1,8 +1,8 @@
> > ## Note, pass them the source xml directory, since they can't find it =
> in VPATH
> > ## builds
> > check:
> > - sh @srcdir@/svn-test.sh @top_srcdir@/subversion/tests-common/xml
> > - sh @srcdir@/svn-test2.sh @top_srcdir@/subversion/tests-common/xml
> > + sh @srcdir@/svn-test.sh @top_srcdir@/subversion/tests/xml
> > + sh @srcdir@/svn-test2.sh @top_srcdir@/subversion/tests/xml
> > =20
> > ## We need to include these in the distribution
> > EXTRA_DIST =3D svn-test.sh svn-test2.sh
> > =20
> --=20
> >~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Kevin Pilch-Bisson
> kevin@pilch-bisson.net
> http://www.pilch-bisson.net
> PGP Public Key At http://pgp.pilch-bisson.net
>
> --1yeeQ81UyVL57Vl7
> Content-Type: application/pgp-signature
> Content-Disposition: inline
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.4 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
>
> iD8DBQE6eAJkgJlk/lQdbnARAm8pAJoD0c4S4CsySp63ckgKASTDEXENQACfS5Nx
> 8znWzgTYWdT+X2WM5+pQ6Fo=
> =QsNG
> -----END PGP SIGNATURE-----
>
> --1yeeQ81UyVL57Vl7--
Received on Sat Oct 21 14:36:20 2006