[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] added db win32 portability includes to build projects

From: <cmpilato_at_collab.net>
Date: 2001-01-30 00:14:24 CET

Branko =?ISO-8859-2?Q?=C8ibej?= <brane@xbc.nu> writes:

> And it goes on to say:
>
> Unpack the distribution, then set the environment variable
> SVN_DB3_WIN32 to the full path of the db-win32 directory (use the
> System control panel on WinNT/Win2k). MSVC will look for the include
> files in $(SVN_DB3_WIN32)\include, and the libraries in
> $(SVN_DB3_WIN32)\lib.

Right. It wasn't clear in the text that you expected a user to have
to manipulate their directory structures in order to fit snugly into
subversion's build system (when building their own DB code from
source). To someone unfamiliar with the problem, it reads as though
one can simply unpack "the distribution" (with no clarification of
that being a source or a binary one), set an environment variable, and
off we go into blissful compilation.

> Oh, well. If sou think it's worth the trouble to change this and force
> everybody to compile their own version of DB3, go ahead. Personally I'd
> rather just put a note in HACKING that you have to copy the include
> files and libraries into the ...\include and ...\lib directories.

And after talking to Karl about the issue, we agree that the note in
HACKING is indeed the easiest solution to the problem. If we get tons
of complaints, we can spend the time to submit a patch to Berkeley
that will create a useful directory structure, or perhaps someone else
will do so.

That said, I accept my rejected patch like a man. :-)
Received on Sat Oct 21 14:36:20 2006

This is an archived mail posted to the Subversion Dev mailing list.