[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch for supporting VPATH builds

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-01-26 09:09:42 CET

On Thu, Jan 25, 2001 at 11:46:29PM -0800, Mo DeJong wrote:
> On Thu, 25 Jan 2001, Greg Stein wrote:
>...
> > We just expect the caller to set the MKDIR macro to a script that does the
> > job. APR sets it to ./helpers/mkdir.sh. Apache sets it to
> > ./srclib/apr/helpers/mkdir.sh. SVN sets it to ./apr/helpers/mkdir.sh.
> >
> > In this way, each "top-level" configure can tell the RUN_SUBDIR_CONFIG where
> > to find the MKDIR script.
> >
> > It is a simpler than the MKDIR macro. However, it does place a burden on the
> > user of RUN_SUBDIR_CONFIG. I've been torn on which is best, so ended up
> > doing nothing :-(
>
> (WARNING: The following is not a flame)

Don't worry about that. I've got builtin asbestos :-)

> You call that simpler?

Simpler within the configure script. But overall? Wasn't sure.

> Why give folks the chance to make an error?
> The APR_MKDIR macro is hidden inside the RUN_SUBDIR_CONFIG
> macro, most folks would never even know it was there.

Right. It was a balance of configure script simplicity vs. simpler for the
user of the RUN_SUBDIR_CONFIG macro. Like I said... I wasn't sure.

[ I also recall a few slight differences between the macro and mkdir.sh;
  never sat down to look at whether those diffs were important ]

> We are
> already running ./configure at this point, why exec another
> sh script? A macro is much faster and you would never need
> to set a path to get it working.

*nod*

I'm still on the fence, probably leaning towards the builtin macro. I just
haven't gotten worked up enough to hop off the fence :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:20 2006

This is an archived mail posted to the Subversion Dev mailing list.